Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-uninstalled-addons) Support Windows paths #112

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Dschungelabenteuer
Copy link
Member

@Dschungelabenteuer Dschungelabenteuer commented Dec 28, 2022

What Changed

image

Running the tests fails on Windows because of the way paths are being resolved inside the no-uninstalled-addons rule.

  • Replaced the relevant / occurrences with path.sep which should just work for both POSIX and Windows.
  • Updated the tests accordingly.

Checklist

Check the ones applicable to your change:

  • Ran yarn update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

@yannbf yannbf added the patch Increment the patch version when merged label Jan 10, 2023
@yannbf
Copy link
Member

yannbf commented Jan 10, 2023

This is great, thanks for your contribution @Dschungelabenteuer !!

@yannbf yannbf merged commit 1397f4f into storybookjs:main Jan 10, 2023
@github-actions
Copy link

🚀 PR was released in v0.6.9 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants