story-exports: Support stories that are function declarations. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's not the form the docs recommend, `export function Primary() {}` is functionally equivalent to `export const Primary = () => {}` and therefore fully supported by Storybook, so it should be fully supported by eslint-plugin-storybook as well.
yannbf
added
release
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: I didn't bother filing one.
What Changed
While it's not the form the docs recommend,
export function Primary() {}is functionally equivalent toexport const Primary = () => {}and therefore fully supported by Storybook, so it should be fully supported by eslint-plugin-storybook as well. This PR is therefore very much in the same vein as #58.I chose not to update the docs for the rule since the function declaration form is not the recommended approach for Storybook, but I'd be happy to include this newly-supported format in the docs if you'd prefer. Just let me know.
In the tests I also added a few missing
dedentcalls and one missingoutputblock for the future when this rule has auto-fixing in place.Checklist
Check the ones applicable to your change:
yarn update-allChange Type
Indicate the type of change your pull request is:
maintenancedocumentationpatchminormajor