Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Update expect to 28 #12

Merged
merged 14 commits into from
Apr 17, 2023
Merged

Update expect to 28 #12

merged 14 commits into from
Apr 17, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Sep 21, 2022

I also removed the typecast, but I'm not certain if that will cause problems. It seems like we shouldn't be changing the type, if all we're doing is re-exporting a version of the package that works in the browser.

It no longer passes typescript check during build
@KubaJastrz
Copy link

Expect 29 is out https://www.npmjs.com/package/expect

@IanVS
Copy link
Member Author

IanVS commented Oct 3, 2022

Yeah, I thought we might want to have both 28 and 29, so I was going to take it one step at a time. Not sure if that's what @yannbf wants to do or not, though.

@yannbf
Copy link
Member

yannbf commented Oct 31, 2022

Hey peeps, just to give you some updates, there are a few typescript issues from this change. We are trying to figure out how to fix them.

@IanVS
Copy link
Member Author

IanVS commented Dec 29, 2022

I gave up on trying to do anything fancy here. I think that there's still a bit of a typescript incompatibility between jest globals, expect, and jest-dom. But, this at least unblocks us and I tested it out in my own project and the types are working now. @yannbf I'd love if we could get some upgraded jest/expect out there with 7.0, so we can stop hacking around global in the vite projects.

@yannbf yannbf added the linear export to linear label Jan 11, 2023
@yannbf
Copy link
Member

yannbf commented Jan 11, 2023

Hey @IanVS thanks a lot, I will discuss with the team and take a look at this as soon as I can! <3

@IanVS
Copy link
Member Author

IanVS commented Feb 16, 2023

Hi, I'd really love to get expect updated. Is there a chance anyone can take a look at it?

@ghengeveld
Copy link
Member

@yannbf and I should discuss and get this sorted.

@socket-security
Copy link

socket-security bot commented Apr 17, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore @sinclair/typebox@0.24.51
  • @SocketSecurity ignore @yarnpkg/lockfile@1.1.0
  • @SocketSecurity ignore find-yarn-workspace-root@2.0.0
⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
@sinclair/typebox@0.24.51 (upgraded) Function conditional/structural.js package.json via @types/jest@28.1.3, expect@28.1.3
@yarnpkg/lockfile@1.1.0 (added) Function index.js package.json via patch-package@6.5.1
@yarnpkg/lockfile@1.1.0 (added) Function index.js package.json via patch-package@6.5.1
⚠️ New author

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Package New Author Previous Author Source
find-yarn-workspace-root@2.0.0 (added) bmishkin square package.json via patch-package@6.5.1
Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ⚠️ 3 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ⚠️ 1 issue
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
patch-package@6.5.1 eval, filesystem, environment +15 ds300
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@types/jest@28.1.3 29.5.0...28.1.3 eval +7/-12 types
expect@28.1.3 27.5.1...28.1.3 None +11/-10 simenb

@ghengeveld ghengeveld merged commit 377cd9a into main Apr 17, 2023
@ghengeveld ghengeveld deleted the expect-28 branch April 17, 2023 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linear export to linear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants