Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canvas mdxSource generation and add tests #25

Merged
merged 14 commits into from
Nov 7, 2022
Merged

Fix canvas mdxSource generation and add tests #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cf3d3e6
feat: used getMdxSource fn.
zhyd1997 Aug 17, 2022
1ddf4f9
fix: ommited 'Canvas' tag in 'mdxSource'.
zhyd1997 Aug 18, 2022
c9c1eb0
fix: handled multiple 'Canvas' elements.
zhyd1997 Aug 18, 2022
0b74cab
refactor: removed unneccessary variable 'canvasEle'.
zhyd1997 Aug 18, 2022
1a738ca
refactor: replaced forEach-if with filter-map statements (more readab…
zhyd1997 Aug 18, 2022
873c587
refactor: split process into smaller fns.
zhyd1997 Aug 18, 2022
98e938f
test: mdxSource.
zhyd1997 Aug 18, 2022
484c8f6
test: addMdxSourceAttribute.
zhyd1997 Aug 18, 2022
f5d297b
test: updated snapshot.
zhyd1997 Aug 18, 2022
29e4d39
Merge branch 'next' into pr/16
shilman Nov 4, 2022
53955e7
Upgrade example to SB7
shilman Nov 4, 2022
3b5b158
Fix canvas mdxSource generation and add tests
shilman Nov 7, 2022
2de60c7
Merge branch 'next' into shilman/18342-fix-canvas-source
shilman Nov 7, 2022
7adf785
Update tests & lockfile
shilman Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
module.exports = {
stories: ['../stories/**/*.stories.mdx', '../stories/**/*.stories.@(js|jsx|ts|tsx)'],
addons: ['@storybook/addon-links', '@storybook/addon-essentials'],
framework: {
name: '@storybook/react-webpack5',
options: {},
},
core: {},
framework: '@storybook/react-webpack5',
webpackFinal: async (config) => {
const rules = (config.module.rules || []).filter(
(rule) => !rule.test?.toString().endsWith('\\.mdx$/')
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@storybook/addon-links": "next",
"@storybook/react": "next",
"@storybook/react-webpack5": "next",
"@storybook/testing-library": "^0.0.14-next.0",
"@storybook/testing-library": "next",
"@testing-library/dom": "^8.1.0",
"@testing-library/react": "^12.0.0",
"@testing-library/user-event": "^13.2.1",
Expand Down
Loading