-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 warnings in new example project, require cycle and duplicate decorator #240
Comments
Thanks for this detailed issue I appreciate it 🙏 . With the duplicate decorator that sounds like it's probably related to fast reload, not sure though. I'll definitely be doing more testing over the coming days to try and find and fix as many issues as possible. If you or anyone else is able to find the cause of these warnings then all contributions are very welcome. Thanks for your interest in this project, I'll keep working to improve it 👍 |
@sangameshsomawar thanks for trying this out, does it stay without warnings if you reload the app? |
@dannyhw |
@sangameshsomawar thanks, maybe its no longer an issue then 🤔 . Or rather it's a problem in 5.3 still but for the upcoming release it will be resolved |
@dannyhw: Yes, the Issue will not be there in new releases I think. You can simulate and confirm once then you can close the issue. 😄 |
I got the same problem. Then, I integrated the react-hook-form and it did NOT work. |
@nguyenvantruong17 are you using v6.0? or 5.3? |
I'm using v5.3. |
BTW. I've fixed that problem by setting inlineRequires = false in metro.config.js file. |
Prompted by Dependabot false positive Security vulnerabilities of dev build tools RN Storybook v5.3 - Remove old /storybook config - Keep old /stories for now RN Storybook v6 - Setup in .storybook for now - Add minimal config w/o stories for now Jest setup mocks - Remove stale RN mocks - Add new RN Storybook mocks - Doc @storybook/addon-ondevice-notes/register parsing issue - Doc @storybook/addon-actions ES forEach proto parsing issue Metro - Config resolver for modern storybook build, vs polyfilled versions - Keep inlineRequires optimisation on, disable later if blocking App - Update gitignore with Storybook - Update app Storybook require to import with new path - Add react-native-slider and RNDateTimePicker pods - Add get-stories script to codegen storybook.requires.js - Update RNCAsyncStorage pod - Remove deprecated @react-native-community/async-storage later and update Reactotron config Relevant Dependabot Security alerts - Upgrading Storybook should clear some, resolve remaining after - browserslist: storybookjs/storybook#15173 - glob-parent : storybookjs/storybook#15174 - Vulnerabilities: storybookjs/storybook#16063 - immer: storybookjs/storybook#16093 - immer: storybookjs/storybook#16556 storybookjs/react-native#240 - Old v5.3 warnings no longer present, in this v6 no-stories but with addons upgrade so far
Prompted by Dependabot false positive Security vulnerabilities of dev build tools RN Storybook v5.3 - Remove old /storybook config - Keep old /stories for now RN Storybook v6 - Setup in .storybook for now - Add minimal config w/o stories for now Jest setup mocks - Remove stale RN mocks - Add new RN Storybook mocks - Doc @storybook/addon-ondevice-notes/register parsing issue - Doc @storybook/addon-actions ES forEach proto parsing issue Metro - Config resolver for modern storybook build, vs polyfilled versions - Keep inlineRequires optimisation on, disable later if blocking App - Update gitignore with Storybook - Update app Storybook require to import with new path - Add react-native-slider and RNDateTimePicker pods - Add get-stories script to codegen storybook.requires.js - Update RNCAsyncStorage pod - Remove deprecated @react-native-community/async-storage later and update Reactotron config Relevant Dependabot Security alerts - Upgrading Storybook should clear some, resolve remaining after - browserslist: storybookjs/storybook#15173 - glob-parent : storybookjs/storybook#15174 - Vulnerabilities: storybookjs/storybook#16063 - immer: storybookjs/storybook#16093 - immer: storybookjs/storybook#16556 storybookjs/react-native#240 - Old v5.3 warnings no longer present, in this v6 no-stories but with addons upgrade so far After figured @storybook/addon-ondevice-notes/register Jest parsing issue - Add generated storybook.requires.js to gitignore - Add prestart script to get-stories first Consider splitting/decoupling App/Storybook Jest parsing - env var with dynamic import - npm workspaces / lerna - multiple modules
no longer getting both original warnings since upgrading to 6 alpha, altho getting a diff one will upgrade to beta soon and raise separately if remains thanks again for checking earlier @sangameshsomawar and @nguyenvantruong17 keep up the good work @dannyhw |
This is also the only solution that I have found thus far. Any file that import Storybook into, my app crashes. Just really strange behavior going on. on v.5.3 |
Description
2 warnings in new project
To Reproduce
yarn
yarn bootstrap
cd examples/native
cd ios && pod install && cd ..
project.pbxproj
to run on M1)yarn start --reset-cache
yarn ios
yarn start --reset-cache
yarn ios
Or
App.tsx
line 117 for storybookyarn
cd ios && pod install && cd ..
yarn start --reset-cache
yarn ios
yarn start --reset-cache
yarn ios
Expected behavior
No warnings
Screenshots
2 Warnings
1
WARN Require cycle: ../../node_modules/util/util.js -> ../../node_modules/util/node_modules/inherits/inherits.js -> ../../node_modules/util/util.js](https://github.com/facebook/metro/issues/287
facebook/metro#287
2
WARN You tried to add a duplicate decorator, this is not expected [Function anonymous]
Cause removed, 0 Warnings
But ofc, we need to call
getStorybookUI({...})
Code snippets
System
Additional context
StorybookUIRoot = getStorybookUI({})
in any project causes warning 1The text was updated successfully, but these errors were encountered: