Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed workflow events #14

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

JonahPlusPlus
Copy link
Collaborator

In the original workflow files, the framework package only gets published when a release is published, but it doesn't depend on any release events, so it must have not worked, or GitHub actions worked differently back then.

This PR fixes it by converting the CD pipeline for the framework package from a pull system to a push system.
In other words, instead of checking if the renderer package pipeline has run, the renderer package pipeline will call the framework package pipeline.

This allows for the renderer package pipeline to provide an input for whether or not to publish, and for the pipelines to be called manually if something goes wrong.

@JonahPlusPlus JonahPlusPlus merged commit 546e301 into storybookjs:main Nov 12, 2024
3 checks passed
@JonahPlusPlus JonahPlusPlus deleted the fix-cd branch November 12, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant