1.0.0-beta.6: Improve code snippets and CD #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, in GH action expressions, nullish values need to be coerced to booleans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes I made in 1.0.0-beta.4 and 1.0.0-beta.5 were nice, but had a couple of bugs and weren't completely satisfactory.
There was a bug I didn't catch when passing expressions to
childrenin stories that caused them to be rendered empty (due to a naming convention that I missed since Babel doesn't have types in the standalone version).I also noticed in my own project that stories using
argsdidn't play well withchildrenthat had complex types and so it was better to use arenderfunction to make the story.This PR fixes the bugs and allows for render functions to be used for code snippets.
It also attempts to fix the CD issues.