Improve error logging (#8155)

Improve error logging Co-authored-by: Norbert de Langen <ndelangen@me.com>
storybookjs · Oct 7, 2019 · 0b7af6e · 0b7af6e
1 parent 169ddd5
commit 0b7af6e
Showing 1 changed file with 12 additions and 15 deletions.
diff --git a/lib/core/src/server/build-dev.js b/lib/core/src/server/build-dev.js
@@ -329,6 +329,15 @@ export async function buildDevStandalone(options) {
     // this is a weird bugfix, somehow 'node-pre-gyp' is polluting the npmLog header
     npmLog.heading = '';
 
+    if (error instanceof Error) {
+      if (error.error) {
+        logger.error(error.error);
+      } else if (error.stats && error.stats.compilation.errors) {
+        error.stats.compilation.errors.forEach(e => logger.plain(e));
+      } else {
+        logger.error(error);
+      }
+    }
     logger.line();
     logger.warn(
       error.close
@@ -337,25 +346,13 @@ export async function buildDevStandalone(options) {
             Fix the error below and restart storybook.
           `
         : stripIndents`
-            Broken build, fix the error below.
+            Broken build, fix the error above.
             You may need to refresh the browser.
           `
     );
     logger.line();
-    if (error instanceof Error) {
-      if (error.error) {
-        logger.error(error.error);
-      } else if (error.stats && error.stats.compilation.errors) {
-        error.stats.compilation.errors.forEach(e => logger.plain(e));
-      } else {
-        logger.error(error);
-      }
-
-      if (error.close) {
-        process.exit(1);
-      }
-    }
-    if (options.smokeTest) {
+
+    if (options.smokeTest || error && error.close) {
       process.exit(1);
     }
   }