Allow Next.js project not having a next.config file

storybookjs · Dec 14, 2022 · 5bf5a31 · 5bf5a31
1 parent 4318e85
commit 5bf5a31
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 32 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,17 +4,17 @@ parameters:
   workflow:
     description: Which workflow to run
     type: enum
-    enum: ["ci", "pr", "merged", "daily"]
-    default: "ci"
+    enum: ['ci', 'pr', 'merged', 'daily']
+    default: 'ci'
 
 executors:
   sb_node_16_classic:
     parameters:
       class:
         description: The Resource class
         type: enum
-        enum: ["small", "medium", "medium+", "large", "xlarge"]
-        default: "small"
+        enum: ['small', 'medium', 'medium+', 'large', 'xlarge']
+        default: 'small'
     working_directory: /tmp/storybook
     docker:
       - image: cimg/node:16.17.1
@@ -26,8 +26,8 @@ executors:
       class:
         description: The Resource class
         type: enum
-        enum: ["small", "medium", "medium+", "large", "xlarge"]
-        default: "small"
+        enum: ['small', 'medium', 'medium+', 'large', 'xlarge']
+        default: 'small'
     working_directory: /tmp/storybook
     docker:
       - image: cimg/node:16.17.1-browsers
@@ -39,8 +39,8 @@ executors:
       class:
         description: The Resource class
         type: enum
-        enum: ["small", "medium", "medium+", "large", "xlarge"]
-        default: "small"
+        enum: ['small', 'medium', 'medium+', 'large', 'xlarge']
+        default: 'small'
     working_directory: /tmp/storybook
     docker:
       - image: mcr.microsoft.com/playwright:v1.28.0-focal
@@ -55,7 +55,7 @@ orbs:
 
 commands:
   cancel-workflow-on-failure:
-    description: "Cancels the entire workflow in case the previous step has failed"
+    description: 'Cancels the entire workflow in case the previous step has failed'
     steps:
       - run:
           name: Cancel current workflow
@@ -65,13 +65,13 @@ commands:
             echo "To execute all checks locally, please run yarn ci-tests"
             curl -X POST --header "Content-Type: application/json" "https://circleci.com/api/v2/workflow/${CIRCLE_WORKFLOW_ID}/cancel?circle-token=${WORKFLOW_CANCELER}"
   report-workflow-on-failure:
-    description: "Reports failures to discord"
+    description: 'Reports failures to discord'
     parameters:
       template:
         description: |
           Which template to report in discord. Applicable for parallel sandbox jobs
         type: string
-        default: "none"
+        default: 'none'
     steps:
       - run:
           when: on_fail
@@ -87,7 +87,7 @@ jobs:
       name: sb_node_16_classic
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - run:
           name: Prettier
           command: |
@@ -100,7 +100,7 @@ jobs:
       name: sb_node_16_classic
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - restore_cache:
           name: Restore Yarn cache
           keys:
@@ -142,7 +142,7 @@ jobs:
     working_directory: /tmp/storybook
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -183,7 +183,7 @@ jobs:
     working_directory: /tmp/storybook
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -223,7 +223,7 @@ jobs:
       name: sb_node_16_classic
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -239,7 +239,7 @@ jobs:
       name: sb_node_16_classic
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -253,7 +253,7 @@ jobs:
     executor: sb_node_16_browsers
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -271,7 +271,7 @@ jobs:
       name: sb_node_16_browsers
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -293,7 +293,7 @@ jobs:
       name: sb_node_16_browsers
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -334,7 +334,7 @@ jobs:
     parallelism: << parameters.parallelism >>
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -359,7 +359,7 @@ jobs:
     parallelism: << parameters.parallelism >>
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -380,7 +380,7 @@ jobs:
     parallelism: << parameters.parallelism >>
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -414,7 +414,7 @@ jobs:
     parallelism: << parameters.parallelism >>
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:
@@ -455,7 +455,7 @@ jobs:
     parallelism: << parameters.parallelism >>
     steps:
       - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
+          clone_options: '--depth 1 --verbose'
       - attach_workspace:
           at: .
       - run:

diff --git a/code/frameworks/nextjs/src/utils.ts b/code/frameworks/nextjs/src/utils.ts
@@ -45,13 +45,7 @@ export const resolveNextConfig = async ({
   const nextConfigFile = nextConfigPath || (await findNextConfigFile(configDir));
 
   if (!nextConfigFile || (await pathExists(nextConfigFile)) === false) {
-    throw new Error(
-      dedent`
-        Could not find or resolve your Next config file. Please provide the next config file path as a framework option.
-
-        More info: https://github.com/storybookjs/storybook/blob/next/code/frameworks/nextjs/README.md#options
-      `
-    );
+    return {};
   }
 
   const nextConfigExport = await import(pathToFileURL(nextConfigFile).href);