add spinners when installing dependencies

storybookjs · May 16, 2023 · b201226 · b201226
1 parent 1fab54d
commit b201226
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/code/lib/cli/package.json b/code/lib/cli/package.json
@@ -81,6 +81,7 @@
     "globby": "^11.0.2",
     "jscodeshift": "^0.14.0",
     "leven": "^3.1.0",
+    "ora": "^5.4.1",
     "prettier": "^2.8.0",
     "prompts": "^2.4.0",
     "puppeteer-core": "^2.1.1",

diff --git a/code/lib/cli/src/generators/baseGenerator.ts b/code/lib/cli/src/generators/baseGenerator.ts
@@ -1,10 +1,11 @@
 import path from 'path';
 import fse from 'fs-extra';
 import { dedent } from 'ts-dedent';
+import ora from 'ora';
 import type { NpmOptions } from '../NpmOptions';
 import type { SupportedRenderers, SupportedFrameworks, Builder } from '../project_types';
 import { SupportedLanguage, externalFrameworks, CoreBuilder } from '../project_types';
-import { copyTemplateFiles, paddedLog } from '../helpers';
+import { copyTemplateFiles } from '../helpers';
 import { configureMain, configurePreview } from './configure';
 import type { JsPackageManager } from '../js-package-manager';
 import { getPackageDetails } from '../js-package-manager';
@@ -17,6 +18,8 @@ import {
   suggestESLintPlugin,
 } from '../automigrate/helpers/eslintPlugin';
 
+const logger = console;
+
 const defaultOptions: FrameworkOptions = {
   extraPackages: [],
   extraAddons: [],
@@ -254,8 +257,13 @@ export async function baseGenerator(
       (packageToInstall) => !installedDependencies.has(getPackageDetails(packageToInstall)[0])
     );
 
-  paddedLog(`\nGetting the correct version of ${packages.length} packages`);
+  logger.log();
+  const versionedPackagesSpinner = ora({
+    indent: 2,
+    text: `Getting the correct version of ${packages.length} packages`,
+  }).start();
   const versionedPackages = await packageManager.getVersionedPackages(packages);
+  versionedPackagesSpinner.succeed();
 
   await fse.ensureDir(`./${storybookConfigFolder}`);
 
@@ -334,8 +342,12 @@ export async function baseGenerator(
   }
 
   if (depsToInstall.length > 0) {
-    paddedLog('Installing Storybook dependencies');
+    const addDependenciesSpinner = ora({
+      indent: 2,
+      text: 'Installing Storybook dependencies',
+    }).start();
     await packageManager.addDependencies({ ...npmOptions, packageJson }, depsToInstall);
+    addDependenciesSpinner.succeed();
   }
 
   if (addScripts) {

diff --git a/code/yarn.lock b/code/yarn.lock
@@ -5742,6 +5742,7 @@ __metadata:
     globby: ^11.0.2
     jscodeshift: ^0.14.0
     leven: ^3.1.0
+    ora: ^5.4.1
     prettier: ^2.8.0
     prompts: ^2.4.0
     puppeteer-core: ^2.1.1