Skip to content

Commit

Permalink
Merge pull request #27168 from storybookjs/yann/remove-sb-testing-lib…
Browse files Browse the repository at this point in the history
…rary

Build: Remove @storybook/testing-library from internal sandbox generation
  • Loading branch information
shilman authored May 25, 2024
2 parents d5a20ab + 9a04b4c commit b94ad44
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 16 deletions.
1 change: 0 additions & 1 deletion code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@
"@storybook/svelte-webpack5": "workspace:*",
"@storybook/telemetry": "workspace:*",
"@storybook/test": "workspace:*",
"@storybook/testing-library": "next",
"@storybook/theming": "workspace:*",
"@storybook/types": "workspace:*",
"@storybook/vue3": "workspace:*",
Expand Down
14 changes: 1 addition & 13 deletions code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6811,7 +6811,6 @@ __metadata:
"@storybook/svelte-webpack5": "workspace:*"
"@storybook/telemetry": "workspace:*"
"@storybook/test": "workspace:*"
"@storybook/testing-library": "npm:next"
"@storybook/theming": "workspace:*"
"@storybook/types": "workspace:*"
"@storybook/vue3": "workspace:*"
Expand Down Expand Up @@ -7081,17 +7080,6 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/testing-library@npm:next":
version: 0.2.2-next.0
resolution: "@storybook/testing-library@npm:0.2.2-next.0"
dependencies:
"@testing-library/dom": "npm:^9.0.0"
"@testing-library/user-event": "npm:^14.4.0"
ts-dedent: "npm:^2.2.0"
checksum: 10c0/4350e73776cba8ab5037ee9a8b07b957c73540873f64097648ed96b93f086469eab475ad19b917e5e2eee4faec67891fa443d703b9b4aa28efc9a74243970a4e
languageName: node
linkType: hard

"@storybook/theming@workspace:*, @storybook/theming@workspace:lib/theming":
version: 0.0.0-use.local
resolution: "@storybook/theming@workspace:lib/theming"
Expand Down Expand Up @@ -7483,7 +7471,7 @@ __metadata:
languageName: node
linkType: hard

"@testing-library/user-event@npm:^14.4.0, @testing-library/user-event@npm:^14.4.3, @testing-library/user-event@npm:^14.5.2":
"@testing-library/user-event@npm:^14.4.3, @testing-library/user-event@npm:^14.5.2":
version: 14.5.2
resolution: "@testing-library/user-event@npm:14.5.2"
peerDependencies:
Expand Down
3 changes: 1 addition & 2 deletions scripts/tasks/sandbox-parts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,7 @@ export async function addExtraDependencies({
debug: boolean;
extraDeps?: string[];
}) {
// web-components doesn't install '@storybook/testing-library' by default
const extraDevDeps = ['@storybook/testing-library@next', '@storybook/test-runner@next'];
const extraDevDeps = ['@storybook/test-runner@next'];
if (debug) logger.log('🎁 Adding extra dev deps', extraDevDeps);
let packageManager: JsPackageManager;
if (!dryRun) {
Expand Down

0 comments on commit b94ad44

Please sign in to comment.