fix: update typing since react 18

storybookjs · Mar 20, 2023 · ba182ea · ba182ea · dahei · Apr 8, 2024
1 parent 11d6265
commit ba182ea
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/code/lib/react-dom-shim/src/react-18.tsx b/code/lib/react-dom-shim/src/react-18.tsx
@@ -1,9 +1,7 @@
 import type { FC, ReactElement } from 'react';
-// @ts-expect-error react-dom doesn't have this in v16, which confuses TS
 import type { Root as ReactRoot } from 'react-dom/client';
 import React, { useLayoutEffect, useRef } from 'react';
-// @ts-expect-error react-dom doesn't have this in v16, which confuses TS
-import ReactDOM from 'react-dom/client'; // eslint-disable-line import/no-unresolved
+import ReactDOM from 'react-dom/client';
 
 // A map of all rendered React 18 nodes
 const nodes = new Map<Element, ReactRoot>();
@@ -41,7 +39,7 @@ export const unmountElement = (el: Element, shouldUseNewRootApi?: boolean) => {
   }
 };
 
-const getReactRoot = async (el: Element): Promise<ReactRoot | null> => {
+const getReactRoot = async (el: Element): Promise<ReactRoot> => {
   let root = nodes.get(el);
 
   if (!root) {