Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React dev tools #102

Closed
rogchap opened this issue Apr 12, 2016 · 13 comments
Closed

React dev tools #102

rogchap opened this issue Apr 12, 2016 · 13 comments

Comments

@rogchap
Copy link

rogchap commented Apr 12, 2016

Firstly, Storybook is a great tool.

Secondly, is it possible use the React (Chrome) dev tools to inspect the components/iframe?

I think this can be enabled by adding (see facebook/react-devtools#76) to the iframe:

if (window.parent !== window) {
  window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = window.parent.__REACT_DEVTOOLS_GLOBAL_HOOK__;
}
@arunoda
Copy link
Member

arunoda commented Apr 12, 2016

I think we should support. Send us a PR.

@rogchap
Copy link
Author

rogchap commented Apr 12, 2016

Cool... I'll look into this. Official assigned! 😄

@arunoda
Copy link
Member

arunoda commented Apr 12, 2016

Awesome.

@wyattdanger
Copy link
Contributor

I was just about to submit a PR for this yesterday. Great timing. Will submit now

@arunoda
Copy link
Member

arunoda commented Apr 13, 2016

Merged #104 and released as v1.11.0

ndelangen pushed a commit that referenced this issue Apr 5, 2017
Update react native version
@nelsonomuto
Copy link

is this broken in v4 I am unable to inspect inside the iframe

@ndelangen
Copy link
Member

Hmm, we'll have to look into it...

This might be the reason it's broken now:
facebook/react-devtools#76 (comment)

ndelangen added a commit that referenced this issue Jul 26, 2018
@ndelangen
Copy link
Member

Yeah I've added it as suggested there and was able to select it in the devtools 🍰

@ndelangen
Copy link
Member

I'll add it in a PR I'm working on!

@nelsonomuto
Copy link

@ndelangen the issue I am facing is with info @storybook/react v4.0.0-alpha.12

@ndelangen
Copy link
Member

@nelsonomuto yes, I'm aware, I think this has been broken for some time, thank you for bringing it to my attention. I've verified it works in the above mentioned branch/PR.

ndelangen added a commit that referenced this issue Aug 2, 2018
@nickserv
Copy link

This is no longer working for me in Storybook 4.0.0 and 4.0.2, despite the fix. Any ideas?

@nickserv
Copy link

I made a new issue for the inspector, the actual elements panel in devtools works fine: #4769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants