-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@storybook/vue floods my console with peer dependency warnings on every upgrade #11492
Comments
I should also note that the |
I should also note that these warnings appear to be unnecessary, I've been using Storybook 6 for a while and have just ignored those warnings, I'm just reminded of them every time I If I do
What's even more odd is that It complains about not having |
Tagging various peer dependencies as optional I think would help some of the warnings under storybook's control: https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.0-alpha.7 containing PR #11628 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
We just upgraded from 5.x to 6.1.21 and we're still getting a bunch of warnings from
This is despite |
Problem remains here as well in 6.1.21. Our project uses neither typescript, react nor react-dom but I still get flooded with warnings about missing peer dependencies for those.
Could this be a problem with yarn? yarnpkg/yarn#5810 Unfortunately we're unable to upgrade to the latest version of yarn until we can upgrade Either way, any input on this would be appreciated. Because of the flood of warnings I find myself easily missing any legitimate ones. |
I think this has to do with how yarn handles peerDependencies: yarnpkg/yarn#5347 (comment) Basically, even though package A depends directly on B and C, and B also has a peer dependency on C, yarn will say that the peer dep isn't fulfilled, because hoisting C isn't guaranteed. In storybook's case, the problem with an example:
will give you: That's because
This was done in 89d0ed9, I guess as a fix for this issue. So I think Meanwhile, you can silence these warnings by depending on the packages directly in your own project. react and react-dom silence 95% of the warnings for me. |
Yes, Reasoning is that we try and prevent multiple versions to be installed. |
So that means these additional packages can be fixed in the same way, right? Should I open a new issue for this? Or should this ticket be reopenend? |
I don't know what to do here, honestly. @shilman any advice? |
I'm also experiencing this issue, getting this:
Not even using React... |
@merceyz does @Narretz 's description of the situation make sense? #11492 (comment) If so, would it be reasonable to mark the |
It would for sure silence them but if the user is installing the addons and the resolve happens from there it will be rely on hoisting, i.e. the warnings are valid, but since you have an alias for |
Was this issue ever resolved? I also have many storybook peer dependencies errors using Nuxt and Yarn... |
I'm facing this issue too on addons, im running this with @storybook/vue
|
This has been an issue for ages now. Bumping this up again, I'd like to stop seeing this useless warnings |
The problem is still here |
Checking in again in September. |
We're having this issue. Installed storybook in my vue3 project with Yarn, and I'm getting Peer Dependency warnings. Note: I installed the version: 7.0.0-alpha.35. |
I think the issue was closed by mistake (because maybe the issue was only partially fixed) ? @shilman @merceyz if those stroybook addons are used on a Vue project, and it works, then for me yes it seems reasonable to mark For now, the only workaround we have, if we want to keep yarn warnings readable, is to install It would be great if we can continue the discussion on this issue :) |
Still have the issue. So annoying...
|
Describe the bug
Installing
@storybook/vue
6 generates a lot of peer dependency warnings, mostly for React and Typescript dependencies. My project uses neither of those things, so it's odd that I'm expected to supply them. If@storybook/core
or the like has a dependency on React, it would be reasonable for@storybook/vue
to fulfill that dependency in its package definition, rather than propagating the missing dependency upwards. I'm also confused about the Typescript dependency, because I would hope that Storybook isn't depending on its consumer to compile its Typescript files?To Reproduce
mkdir temp; cd temp;
next
tag:yarn add -D @storybook/vue@next vue-loader vue-template-compiler @babel/core babel-loader babel-preset-vue
The text was updated successfully, but these errors were encountered: