Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for toggling addons panel #17227

Closed
shilman opened this issue Jan 13, 2022 · 7 comments
Closed

UI for toggling addons panel #17227

shilman opened this issue Jan 13, 2022 · 7 comments

Comments

@shilman
Copy link
Member

shilman commented Jan 13, 2022

Currently it's possible to show and hide the sidebar with a UI thanks to #15369

Among other things, this makes the sidebar discoverable if it gets accidentally collapsed via a toolbar shortcut.

We should have the same thing for the addons panel, esp. since there might be a long-standing bug that hides the addon panel

@Tomastomaslol
Copy link
Member

Tomastomaslol commented Jan 18, 2022

Hi @shilman!

Would something like this work?

Kapture.2022-01-18.at.19.11.47.mp4

Is there an icon that is used to describe the addons panel?

@shilman
Copy link
Member Author

shilman commented Jan 18, 2022

@Tomastomaslol Awesome! I think we have a design in mind for this. @MichaelArestad can you share a screenshot?

@Pepijnk12
Copy link
Contributor

I would like to work on this. Is the design ready?

@MichaelArestad
Copy link
Contributor

Alrighty. Sorry for the delay.

Let's add an IconButton to the toolbar just to the left of the full screen icon.

  1. The icon should only be visible when the addon panel is closed.
  2. The specific icon change to reflect that last known dock state of the addon panel (right or bottom). If we don't know the last state, it should default to the bottom.

Screenshot

image

Icons proposed

  1. bottombartoggle
  2. sidebaralttoggle

@Tomastomaslol
Copy link
Member

Tomastomaslol commented Mar 14, 2022

Thanks, @MichaelArestad! I should be able to open a PR fairly soon.

@Tomastomaslol
Copy link
Member

@MichaelArestad @shilman

I just opened #17714. Please let me know if you like the implementation and if there anything i can do to improve the code! :)

Kapture.2022-03-15.at.18.37.33.mp4

@shilman
Copy link
Member Author

shilman commented Mar 23, 2022

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.50 containing PR #17714 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants