Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store panel visibility / full screen mode into permalink or local storage #180

Closed
timkindberg opened this issue May 9, 2016 · 6 comments · Fixed by storybook-eol/storybook-ui#5

Comments

@timkindberg
Copy link
Contributor

I'd love if the panel visible states and the full screen mode were stored in the permalink or local storage. That way when I refresh (sometimes) I don't have to enter full screen mode again (or hide panels again).

@timkindberg
Copy link
Contributor Author

Local storage probably makes more sense, that way if I share a url it will retain the settings on the person's computer, instead of whatever I had set to.

@arunoda
Copy link
Member

arunoda commented May 10, 2016

Hmm.
I like putting them in the URL.

if I share a url it will retain the settings on the person's computer, instead of whatever I had set to.

I'm think this in the other way around :)

@ritz078
Copy link
Contributor

ritz078 commented Jun 6, 2016

A complete isolated view will be great having just the component and nothing else. like full screen but no need of iframe too or any other JS. Just like you plug your component in a clean HTML page. This will help while profiling as you will only see your functions.

@timkindberg
Copy link
Contributor Author

@ritz078 that already exists with Ctrl Shift F

@timkindberg
Copy link
Contributor Author

I've picked up this story! PR coming right now.

@arunoda
Copy link
Member

arunoda commented Jun 19, 2016

Thanks. Will be working on the getting the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants