Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sidebar doesn't wrap which hides the "Run tests" and "Settings" buttons #27206

Closed
domyen opened this issue May 20, 2024 · 11 comments · Fixed by #29055
Closed

[Bug]: Sidebar doesn't wrap which hides the "Run tests" and "Settings" buttons #27206

domyen opened this issue May 20, 2024 · 11 comments · Fixed by #29055

Comments

@domyen
Copy link
Member

domyen commented May 20, 2024

Describe the bug

The sidebar isn’t allowing the items within it to wrap. When I shrink the sidebar width, at a certain point the items no longer wrap and their right hand side gets cutoff.

This is a problem because:

  1. You can't see settings or run tests button
  2. You can't see story status badges

Repro from Chromatic’s own Storybook today.

2024-05-16 16 58 09

Reproduction link

https://59c59bd0183bd100364e1d57-xclhbxlsoy.chromatic.com/

Reproduction steps

  1. Drag the sidebar left and right and see that the items don't wrap correctly

System

This is reproducible using a published Storybook in your browser

Additional context

No response

@H0onnn
Copy link

H0onnn commented May 21, 2024

@domyen @vanessayuenn Hello ! I would like to solve this problem. Can you assign it to me ?

@vanessayuenn
Copy link
Contributor

@H0onnn we don't reserve "good first issues", so feel free to just open a PR for this issue. Be sure to check the contribution guide and hop onto the Storybook Discord if you need any help getting started. Looking forward to your contribution! ✨

@H0onnn
Copy link

H0onnn commented May 22, 2024

Hello ! I'd like to get some help on this issue. I don't have this problem in my local dev environment and in the Storybook environment deployed with chromatic. Where can I find the problem?

@vanessayuenn
Copy link
Contributor

@H0onnn This seems to only happen when there are composed Storybooks. Made you a new repro: https://stackblitz.com/edit/github-qngcps?file=README.md!

@ShreySinha02
Copy link
Contributor

@domyen @vanessayuenn hii can you please assign me this issue

@ShreySinha02
Copy link
Contributor

Screencast from 04-09-24 11:18:29 PM IST.webm
I found the same problem in my local

@ShreySinha02
Copy link
Contributor

ShreySinha02 commented Sep 4, 2024

@domyen @vanessayuenn please review this PR #29049

@H0onnn
Copy link

H0onnn commented Sep 5, 2024

@ShreySinha02 There is already a PR I posted

@ShreySinha02
Copy link
Contributor

@H0onnn still facing the issue that's why i raised pr

@domyen
Copy link
Member Author

domyen commented Sep 5, 2024

@ShreySinha02 thanks for submitting the PR. The underlying issue is caused by the heading of composed Storybooks horizontally extending in a way that affects scroll position.

@H0onnn thanks for the exquisite detail in your PR. Much appreciated. I'm going to loop in @JReinhold who built the sidebar to confirm.

@JReinhold
Copy link
Contributor

@H0onnn and @ShreySinha02, thank you very much for your detailed insights into the issue. I did some research into your investigations and discovered that the root cause was actually fixed upstream in Radix some time ago. So I think the proper fix is just to upgrade the library.

I'm closing your PRs in favor of that change instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment