Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library upgrade of react-treebeard to 3.2.0 breaks storybook ui. #6492

Closed
bbellmyers opened this issue Apr 11, 2019 · 7 comments
Closed

Library upgrade of react-treebeard to 3.2.0 breaks storybook ui. #6492

bbellmyers opened this issue Apr 11, 2019 · 7 comments

Comments

@bbellmyers
Copy link

Describe the bug
Running an upgrade on storybook upgrades react-treebeard dependency to 3.2.0, which breaks storybook/ui.

To Reproduce
Steps to reproduce the behavior:

  1. delete node_modules and package-lock.json
  2. Run npm install
  3. run storybook
  4. Storybook starts, but then immediately becomes a blank page, console shows errors with TreeBeard.

Expected behavior
Storybook should start

Screenshots
.. blank screen

Code snippets
.. not applicable

System:

  • OS: MacOS
  • Device: Macbook Pro 2018
  • Browser: chrome
  • Framework: react
  • Version: 1.0.0

Additional context
Suggest either changing package.json from "^3.1.0" to "3.1.0" to prevent auto upgrade, OR, fix codebase to work with updated react-treebeard library.

Error:

The above error occurred in the <Container> component:
    in Container (created by ContainerDecorator)
    in div (created by MenuItem)
    in MenuItem (created by ContainerDecorator)
    in ContainerDecorator (created by Context.Consumer)
    in Unknown (created by NodeHeader)
    in NodeHeader (created by TreeNode)
    in li (created by Context.Consumer)
    in Styled(li) (created by TreeNode)
    in TreeNode (created by TreeNode)
    in ul (created by Context.Consumer)
    in Styled(ul) (created by TreeNode)
    in Transition (created by VelocityTransitionGroupChild)
    in VelocityTransitionGroupChild (created by VelocityTransitionGroup)
    in div (created by TransitionGroup)
    in TransitionGroup (created by VelocityTransitionGroup)
    in VelocityTransitionGroup (created by Drawer)
    in Drawer (created by TreeNode)
    in li (created by Context.Consumer)
    in Styled(li) (created by TreeNode)
    in TreeNode (created by TreeBeard)
    in ul (created by Context.Consumer)
    in Styled(ul) (created by TreeBeard)
    in TreeBeard (created by Stories)
    in div (created by Context.Consumer)
    in Styled(div) (created by ForwardRef)
    in ForwardRef (created by Stories)
    in Stories (created by StoriesPanel)
    in div (created by Context.Consumer)
    in Styled(div) (created by ForwardRef)
    in ForwardRef (created by StoriesPanel)
    in StoriesPanel (created by Container(StoriesPanel))
    in Container(StoriesPanel) (created by storiesPanel)
    in storiesPanel (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by ForwardRef)
    in ForwardRef (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by ForwardRef)
    in ForwardRef (created by Layout)
    in div
    in Pane
    in div
    in SplitPane (created by Layout)
    in Layout (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by ForwardRef)
    in ForwardRef (created by Layout)
    in div (created by Layout)
    in Unknown (created by Layout)
    in Layout (created by Container(Layout))
    in Container(Layout)
    in div
@shilman
Copy link
Member

shilman commented Apr 11, 2019

What version of Storybook?

@piperchester
Copy link
Contributor

piperchester commented Apr 12, 2019

@shilman we're seeing this break on ^4.1.16.

Like @bbelmyers mentions, we solved by hoisting react-treebeard to a top level devDep, and pegging it at 3.1.0.

@shilman shilman self-assigned this Apr 12, 2019
@shilman
Copy link
Member

shilman commented Apr 12, 2019

Thanks for the heads up. 🙏 I'll update 4.x this weekend!

@jantimon
Copy link

Can confirm - we had the same issue (which caused an empty storybook with that stack trace).
Using the older react-treebreard version fixed it.

Thanks a lot @piperchester and @shilman

@gilmoreorless
Copy link

For anyone using Yarn, forcing react-treebeard to install 3.1.0 via resolutions worked for me:

// package.json
{
  // <other package.json fields here>
  "resolutions": {
    "react-treebeard": "3.1.0"
  }
}

Then run yarn install to update the yarn.lock file.

@shilman
Copy link
Member

shilman commented Apr 15, 2019

cc @maximilianoforlenza @ndelangen

@shilman
Copy link
Member

shilman commented Apr 15, 2019

Released: https://github.com/storybooks/storybook/releases/tag/v4.1.18

Closing -- please LMK if there are any problems with the release!

@shilman shilman closed this as completed Apr 15, 2019
gaarf added a commit to gaarf/components that referenced this issue May 10, 2020
I noticed the storybook hosted at https://blockchain.github.io/components/ fails to load. A quick search points to a transitive dependency issue described here: storybookjs/storybook#6492

Updating storybook to the latest minor version resolves the issue, at least locally for me.
schnogz pushed a commit to blockchain/components that referenced this issue May 11, 2020
I noticed the storybook hosted at https://blockchain.github.io/components/ fails to load. A quick search points to a transitive dependency issue described here: storybookjs/storybook#6492

Updating storybook to the latest minor version resolves the issue, at least locally for me.
michael-mdev pushed a commit to michael-mdev/React-Crypto-components that referenced this issue Apr 28, 2021
I noticed the storybook hosted at https://blockchain.github.io/components/ fails to load. A quick search points to a transitive dependency issue described here: storybookjs/storybook#6492

Updating storybook to the latest minor version resolves the issue, at least locally for me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants