Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated issue triage guidelines #1024

Merged
merged 4 commits into from
May 17, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented May 12, 2017

Issue: #733

What I did

@tmeasday and I sat down and reworked the issue labels in the Storybooks repo. This change summarizes the changes we made. Separately we will propose some guidelines around closing issues that have gone stale, etc.

How to test

N/A

@tmeasday
Copy link
Member

@shilman I think this branch is messed up, I don't see any changes

@shilman
Copy link
Member Author

shilman commented May 12, 2017

@tmeasday sorry my bad. fixed!

@codecov
Copy link

codecov bot commented May 12, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@a9944e1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1024   +/-   ##
=========================================
  Coverage          ?   12.51%           
=========================================
  Files             ?      196           
  Lines             ?     4458           
  Branches          ?      713           
=========================================
  Hits              ?      558           
  Misses            ?     3269           
  Partials          ?      631

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9944e1...674d6e2. Read the comment docs.

@tmeasday
Copy link
Member

Looks good--want to add a description of what maintenance and greenkeeper mean too?

Once you've helped out on a few issues, if you'd like triage access you can help label issues and respond to reporters.

We use the following label scheme to categorize issues:
- **type** - `bug`, `feature`, `question / support`, `discussion`, `greenkeeper`, `maintenance`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a label feature / change request might be more descriptive.

CONTRIBUTING.md Outdated
@@ -111,13 +120,12 @@ If an issue is a `bug`, and it doesn't have a clear reproduction that you have p

- `bug`s should be closed when the issue is fixed and merged to `master`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged to master or released?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think merged myself. Otherwise we need another label fixed or the like and we mentally have to ignore fixed issues. I appreciate users might not find an issue that has been closed but not yet released however.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although maybe it's easier for us to ignore fixed issues, and we can use them to construct a meaningful changelog. I change my vote ;)

@ndelangen
Copy link
Member

Good work!

@usulpro
Copy link
Member

usulpro commented May 16, 2017

Could we add a description or clarify use cases for labels:

does documentation include cases when we need documentation? And how should we handle situations when merging PR which adds a feature but does not document it. Should we keep the documentation label on this merged PR and remove it as soon as it adds to documentation?

One more not related to this PR but possible worth to discuss. Should we ask people to add [prefix] with area/type label when they submitting an issue/PR since they can't add labels themselves?

@shilman
Copy link
Member Author

shilman commented May 17, 2017

@usulpro Those are all great points. I'm going to merge this now and will follow up on the status-related labels in a separate PR.

@shilman shilman merged commit f5bf4dd into storybookjs:master May 17, 2017
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog documentation maintenance User-facing maintenance tasks and removed cleanup Minor cleanup style change that won't show up in release changelog labels May 27, 2017
Copy link

nx-cloud bot commented Oct 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 674d6e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants