-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate builtin addons (links and actions) - no longer included by default #1038
Deprecate builtin addons (links and actions) - no longer included by default #1038
Conversation
Added HISTORY.md to track changes with each release, modeled after Meteor’s: https://github.com/meteor/meteor/blob/devel/History.md
Codecov Report
@@ Coverage Diff @@
## master #1038 +/- ##
=========================================
Coverage ? 12.51%
=========================================
Files ? 196
Lines ? 4458
Branches ? 713
=========================================
Hits ? 558
Misses ? 3269
Partials ? 631 Continue to review full report at Codecov.
|
I wonder can we additionally add a deprecating warning to |
@usulpro I'm not sure I understand your comment. I just deprecated the builtin-ness of the addons, not the addons themselves, so I don't think it's appropriate to deprecate them. What do you think? |
I think @shilman means we can deprecate all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a before and after code example would make this text a lot more understandable.
OK I understand @usulpro 's |
@ndelangen Added before/after example. Not sure whether this is the best place for it or format. Suggestions welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: #1017
What I did
Added HISTORY.md to track changes with each release, modeled after
Meteor’s: https://github.com/meteor/meteor/blob/devel/History.md
How to test
Follow instructions in HISTORY.md (if you want)