FIX ref getSourceType for paths with */index.html #10421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10324
index.html
, storybook breaks. I (along with anyone doing this at my company) can't fix this by removingindex.html
from the browser url because an internal platform requires it in order to render the file.What I did
getSourceType
to return'local'
if source matches location withindex.html
in pathname.refs.test.js
to test this edge case and other cases - I needed to mock different values with theglobal.location
. Not too happy with the implementation but I don't know another way to change a mock module between tests.How to test
yarn serve-storybooks