Adds support for preLoaders in custom webpack config #107
Conversation
| @@ -56,6 +56,9 @@ export default function (baseConfig, configDir) { | |||
| module: { | |||
| ...config.module, | |||
| // We need to use our and custom loaders. | |||
| preLoaders: [ | |||
There was a problem hiding this comment.
Actually, there's a much better generic way to deal with this.
Try this instead of this one. I hope it'll work.
...customConfig.module || {},If this works, send me a PR with that.
There was a problem hiding this comment.
I think we need on each loader, because if we default to empty object it won't use default config.
There was a problem hiding this comment.
Yep, this won't work, if we do it ^ this way and customConfig.module contains loader it will override loader in config.module.
There was a problem hiding this comment.
Hmm. Did you try that, it's add loaders but in the line 62 it'll get override again with the our own loaders?
If that's not working, I'll take this in.
There was a problem hiding this comment.
Ahh I see. Sorry I misunderstood, I thought you meant remove whole loaders: [] block too. But this works nicely. Thanks!
…Support for postLoaders
|
This is great. Thanks. |
|
Released with |
* Adds support for preLoaders in custom webpack config * Changes the way it loads custom webpacck config to more generic way. Support for postLoaders
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2005b27. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Fixes #90
Adds support for preLoaders to be added to custom webpack config. This allows you to use preLoaders that need to be run before loaders, like code linting, hinting etc.
Was considering adding support for postLoaders too, but I don't have any experience with them so will leave it for now.