Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add babel plugin for typescript decorators #11063

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Core: Add babel plugin for typescript decorators #11063

merged 2 commits into from
Jun 11, 2020

Conversation

fernandopasik
Copy link
Member

@fernandopasik fernandopasik commented Jun 6, 2020 •
edited by shilman
Loading

Issue: #11061

What I did

  • Added the @babel/plugin-proposal-decorators to the babel config

How to test

  • I've tested it locally but I'd like to add a new example in the kitchen sink apps.

@fernandopasik fernandopasik mentioned this pull request Jun 6, 2020
Closed
mrmckeb
mrmckeb approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this is the correct behaviour, reference:
https://babeljs.io/docs/en/babel-plugin-transform-typescript#typescript-compiler-options

@mrmckeb
Copy link
Member

mrmckeb commented Jun 6, 2020

I've added that comment, good to merge if you're OK with it @shilman!

@mrmckeb mrmckeb requested a review from shilman June 6, 2020 13:19
@shilman shilman changed the title Add babel plugin for typescript decorators Core: Add babel plugin for typescript decorators Jun 11, 2020
@shilman shilman merged commit 7634d0f into next Jun 11, 2020
@fernandopasik fernandopasik deleted the decorators-support branch June 11, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmckeb mrmckeb mrmckeb approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
configuration babel / webpack feature request typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fernandopasik @mrmckeb @shilman