Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added help text to the react-native preview panel #1142

Merged
merged 1 commit into from
May 28, 2017

Conversation

matt-oakes
Copy link
Contributor

What I did

I have added some help text into the preview panel for React Native projects. I took the text from the README and added it into the blank preview panel to give hints into using the tool if the user opens the browser UI first.

Currently, it's ugly but functional:

image

How to test

Open the browser UI for a React Native project and look in the preview panel.

@codecov
Copy link

codecov bot commented May 28, 2017

Codecov Report

Merging #1142 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
- Coverage   12.84%   12.75%   -0.09%     
==========================================
  Files         198      199       +1     
  Lines        4540     4571      +31     
  Branches      718      724       +6     
==========================================
  Hits          583      583              
- Misses       3322     3347      +25     
- Partials      635      641       +6
Impacted Files Coverage Δ
app/react-native/src/manager/provider.js 0% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af985d1...5ed72e8. Read the comment docs.

@shilman shilman self-requested a review May 28, 2017 10:35
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt-oakes Thanks for this wonderful and useful idea. It will be a huge improvement for the RN experience!

My one request is to make it look a little more Storybook-like before we merge. Borrowing a few lines from the cli's Welcome should do the trick:

https://github.com/storybooks/storybook/blob/master/lib/cli/generators/WEBPACK_REACT/template/stories/Welcome.js

@matt-oakes
Copy link
Contributor Author

@shilman Ahhh! As I've only used the React Native version I hadn't seen that screen before.

I have borrowed the styling and taking the first paragraph and combined it with the device running instructions. It now looks like this:

image

Let me know if you want me to make any more changes.

@shilman
Copy link
Member

shilman commented May 28, 2017

@matt-oakes Beautiful!!!

@shilman shilman merged commit cd51a36 into storybookjs:master May 28, 2017
@shilman shilman changed the title Add some help text into the react-native preview panel Added help text to the react-native preview panel May 28, 2017
@matt-oakes
Copy link
Contributor Author

@shilman I think beautiful might be overstating it a bit, but thank you 😉

@matt-oakes matt-oakes deleted the react-native-info branch May 28, 2017 13:23
@shilman
Copy link
Member

shilman commented May 28, 2017

@matt-oakes "relatively beautiful" then? anyway, it should make a night-and-day difference to the onboarding experience for RN. i'm thrilled at this addition.

@matt-oakes
Copy link
Contributor Author

@shilman Yep, hopefully it will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants