Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect babel config file reading #1156

Merged
merged 4 commits into from
May 30, 2017

Conversation

alvaropinot
Copy link
Contributor

Issue: #1148

What I did

  • Add a basic test suite for babel_config that tests:

    • A plugins key present as an array.
    • A plugins key present as a string.
    • No plugins key present.
  • Ensure that the config loads correctly in those 3 scenarios.

How to test

run:

 ./node_modules/jest/bin/jest.js babel_config

or manually use a .babelrc config file that follows those 3 scenarios.

@codecov
Copy link

codecov bot commented May 30, 2017

Codecov Report

Merging #1156 into master will increase coverage by 0.59%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
+ Coverage   12.72%   13.31%   +0.59%     
==========================================
  Files         199      199              
  Lines        4582     4589       +7     
  Branches      727      725       -2     
==========================================
+ Hits          583      611      +28     
+ Misses       3356     3349       -7     
+ Partials      643      629      -14
Impacted Files Coverage Δ
app/react/src/server/babel_config.js 44.82% <33.33%> (+44.82%) ⬆️
app/react/src/server/config/babel.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a7edb...3a8e2d3. Read the comment docs.

@alvaropinot alvaropinot changed the title Fix/babel config [WIP] Fix/babel config May 30, 2017
@alvaropinot alvaropinot force-pushed the fix/babel-config branch 5 times, most recently from 09f33fd to a60887d Compare May 30, 2017 11:23
@alvaropinot alvaropinot changed the title [WIP] Fix/babel config fix incorrect babel config file reading May 30, 2017
@ndelangen ndelangen changed the title fix incorrect babel config file reading Fix incorrect babel config file reading May 30, 2017
@ndelangen ndelangen added compatibility with other tools maintenance User-facing maintenance tasks labels May 30, 2017
@ndelangen
Copy link
Member

ndelangen commented May 30, 2017

Wow, can we have more of these PRs? ❤️ the unit tests!

Let me know if there's anything I can do for you.

@ndelangen ndelangen merged commit 585becc into storybookjs:master May 30, 2017
@ndelangen ndelangen added this to the v3.0.1 milestone May 30, 2017
@alvaropinot alvaropinot deleted the fix/babel-config branch May 31, 2017 05:29
@shilman shilman added bug and removed maintenance User-facing maintenance tasks labels Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants