-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect babel config file reading #1156
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
+ Coverage 12.72% 13.31% +0.59%
==========================================
Files 199 199
Lines 4582 4589 +7
Branches 727 725 -2
==========================================
+ Hits 583 611 +28
+ Misses 3356 3349 -7
+ Partials 643 629 -14
Continue to review full report at Codecov.
|
09f33fd
to
a60887d
Compare
a60887d
to
e28bf25
Compare
Wow, can we have more of these PRs? ❤️ the unit tests! Let me know if there's anything I can do for you. |
Issue: #1148
What I did
Add a basic test suite for
babel_config
that tests:plugins
key present as an array.plugins
key present as a string.plugins
key present.Ensure that the config loads correctly in those 3 scenarios.
How to test
run:
or manually use a
.babelrc
config file that follows those 3 scenarios.