Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-controls: Fix undefined args handling #11619

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 20, 2020

Issue: #11586

What I did

  • Fix Text handling of undefined input values
  • Add stories for undefined values for all control types

How to test

See original repro in #11586 and also updated stories

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 920b9a7 into next Jul 20, 2020
@stof stof deleted the 11586-fix-args-refresh branch May 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants