-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Generate docs:json
command dynamically for Angular project
#11622
Merged
shilman
merged 2 commits into
next
from
fix/11609-generate-docs-json-command-dynamically
Jul 21, 2020
Merged
CLI: Generate docs:json
command dynamically for Angular project
#11622
shilman
merged 2 commits into
next
from
fix/11609-generate-docs-json-command-dynamically
Jul 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config file Angular CLI 10 introduced a `tsconfig.base.json` file that we have to use to generate doc with compodoc. So if `tsconfig.base.json` exist then use it, otherwise assume there is a `tsconfig.json` file
Example stories used in CLI have been updated recently however the E2E tests were not changed accordingly.
gaetanmaisse
force-pushed
the
fix/11609-generate-docs-json-command-dynamically
branch
from
July 20, 2020 20:05
b783ffc
to
6d79ed2
Compare
Everything else is 🆗 |
gaetanmaisse
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
July 20, 2020 20:06
shilman
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gaetanmaisse 🙏
Can we remove the e2e for |
This was referenced Dec 28, 2020
This was referenced Nov 25, 2023
This was referenced Nov 26, 2023
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced May 13, 2024
This was referenced May 14, 2024
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #11609
What I did
tsconfig.base.json
file that we have to use to generate doc with compodoc. So iftsconfig.base.json
exists then use it, otherwise assume there is atsconfig.json
file.addon-viewport
to match the latest example storiesHow to test
docs:json
commands are OK.