syntax highlighting in action logger #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ritz078
commented
Apr 18, 2016
ritz078
commented
| @@ -25,7 +25,7 @@ describe('<Foldable />', function () { | |||
| args: 'things', | |||
| }; | |||
|
|
|||
| const fullString = '{\n "name": "test action",\n "args": "things"\n}'; | |||
| const fullString = '{\n name: "test action",\n args: "things"\n}'; | |||
There was a problem hiding this comment.
Can't we write an additional test case targetted for syntax highlighting.
|
Overall, this looks cool. |
|
@arunoda added tests and comment |
|
Okay. Great. |
|
Published as |
wyattdanger
pushed a commit
to wyattdanger/react-storybook
that referenced
this pull request
Apr 26, 2016
* feat(highlight):added syntax highlighting in the action logger * fix lint error * fixed tests * added tests for highlight
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3e2d64f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.