Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Updates for the code snippets #11878

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Chore: Updates for the code snippets #11878

merged 2 commits into from
Aug 11, 2020

Conversation

jonniebigodes
Copy link
Contributor

This pull request addresses some of the feedback for the documentation:

What was done:

  • The json/shell snippets are removed and their content is now shown in the markdown file.
  • The writing docs snippets, the mdx examples are updated.

Feel free to provide feedback.

@jonniebigodes
removes the shell and json file references.
714076b 
Updates for the writing docs section
tmeasday
tmeasday approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's move a couple comments

docs/snippets/common/badge-story.mdx.mdx Outdated Show resolved Hide resolved
docs/snippets/common/checkbox-story.mdx.mdx Outdated Show resolved Hide resolved
docs/snippets/common/component-story-mdx-story-by-name.mdx.mdx Outdated Show resolved Hide resolved
docs/snippets/common/mdx-canvas-multiple-stories.mdx.mdx Outdated Show resolved Hide resolved
@shilman shilman merged commit 1a8351e into next Aug 11, 2020
@stof stof deleted the documentation_snippets_updates branch May 25, 2022 09:33
This was referenced Feb 15, 2024
Open
Open
This was referenced Mar 22, 2024
Open
Open
This was referenced Apr 29, 2024
Open
Open
Open
Open
Open
This was referenced May 7, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@shilman shilman Awaiting requested review from shilman

@domyen domyen Awaiting requested review from domyen

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonniebigodes @tmeasday @shilman