Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy of invalid glob warning #12739

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix copy of invalid glob warning #12739

merged 1 commit into from
Oct 12, 2020

Conversation

ZahraTee
Copy link
Contributor

@ZahraTee ZahraTee commented Oct 12, 2020

Issue:

What I did

I noticed while upgrading from Storybook 5 to 6 today that the warning message shown in the console when you've specified an invalid glob has a typo or grammar error. I corrected the typo and tweaked the copy to remove the third usage of the word "glob" to make it feel less wordy. 📝

How to test

Simple string update, no testing required.

@ZahraTee
Copy link
Contributor Author

Closing and re-opening to retrigger Dangerfile check. (Couldn't find a re-run button 😬)

@ZahraTee ZahraTee closed this Oct 12, 2020
@ZahraTee ZahraTee reopened this Oct 12, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZahraTee, that reads much better!

(PS - don't worry about Danger, it only works for local branches not forks!)

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 12, 2020
@shilman shilman merged commit ece3a9b into storybookjs:next Oct 12, 2020
@ZahraTee ZahraTee deleted the fix-invalid-glob-message branch October 12, 2020 11:38
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 16, 2020
shilman added a commit that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants