-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix app entrypoint bug in RN gestorybook #1280
Conversation
- replace APP_NAME in the correct file - add a warning if APP_NAME cannot be found
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 13.71% 13.73% +0.02%
==========================================
Files 207 207
Lines 4646 4638 -8
Branches 526 638 +112
==========================================
Hits 637 637
+ Misses 3542 3443 -99
- Partials 467 558 +91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Great job
Issue: #1277
What I did
How to test
Run
getstorybook
in a fresh RN app and check the results