Core: Remove webpack DLLs #12975
Merged
Core: Remove webpack DLLs #12975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
alterx,
igor-dv,
ndelangen and
tmeasday
as code owners
ScriptedAlchemy
approved these changes
Nov 1, 2020
|
We will be replacing that with something a little better soon ;) |
tmeasday
approved these changes
Nov 2, 2020
| @@ -43,7 +41,7 @@ Usage: build-storybook [options] | |||
|
|
|||
| <summary><h4>Troubleshooting routing issues with Storybook 6.0</h4></summary> | |||
|
|
|||
| If you are building your Storybook and you encounter an issue where you cannot change the route in the sidebar, try building Storybook with the `--no-dll` flag and see if it solves the problem. If so, adjust your `build-storybook` script accordingly to include this flag. We would like to point out that your build process will run slower than usual when using this flag. | |||
| If you are building your Storybook and you encounter an issue where you cannot change the route in the sidebar, try building Storybook with the `--no-dll` flag and see if it solves the problem. If so, adjust your `build-storybook` script accordingly to include this flag. We would like to point out that your build process will run slower than usual when using this flag. | |||
|
self-merging @tmeasday @ndelangen @ghengeveld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12637
What I did
Remove prebuilt DLLs
How to test
CI passes