Decorator less addons (experiment on KNOBS) #1304
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I started experimenting with decoratorless addons after a discussion with @ndelangen.
I tried it out and could knobs "work" (only updating values no reset etc) with a decorator.
I think that's pretty cool, and we should maybe add it to the api somehow as a good practice pattern.
My opinion is that with such an approach. We can lift the refreshing need etc in the api and let user use our addons without too much thinking.
If they really need a decorator that should be for a specific use case (theme etc) that maybe we should let the user handle on it's own.
This is just an experiment but might be worse thinking about for the addon api v2 😄