upgrades including webpack 5 #13392
Closed
upgrades including webpack 5 #13392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday and
usulpro
as code owners
ndelangen
removed request for
theinterned,
aaronmcadam,
kazupon,
thani-sh,
alterx,
leonrodenburg and
thomasbertet
ndelangen
requested review from
mrmckeb
and removed request for
stijnkoopal,
jbovenschen,
alexandrebodin,
igor-dv,
usulpro and
CodeByAlex
Closed
Closed
|
Is this also now stale? |
3 tasks
|
Would it be possible to publish a special alpha release on npm from this branch? Since it's not possible to install github sub-directories with npm, that means folks would have to tarball a cloned version. We've moved completely to Webpack 5 and I imagine a lot of folks who have moved to Webpack 5 do not need Webpack 4 backwards compat. So while you guys sort that out we can use |
|
@timkindberg hoping to have a version to release in a proper alpha next week #13808 |
|
closing in favor of #13808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9216
What I did
I think this PR replaces:
#12999
#12964
#11326
This PR should be broken into multiple smaller PRs, really this was a spike to try how close we are to webpack 5 support.
We should collaborate with CRA (@mrmckeb ) on when webpack 5 support is planned.
This PR has NO backwards compatibility for webpack 4. So we either have to come up with a strategy to add backwards compatibility somehow, OR this is a major breaking change, and a pretty disruptive one at that.