IE11: Transpile prettier down to ES5 #14047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13562 In a Pull Request that adds dynamic source rendering feature for Vue.js [0], prettier was added as regular dependency. It broke IE11 (ES5) compatibility because prettier is published in ES2015 or later. This commit make Storybook's webpack config to transpile prettier down to ES5. [0] ... #12812
pocka
force-pushed
the
pocka/fix/transpile-prettier
branch
from
0384274
to
896c46f
Compare
shilman
changed the title
shilman
added
the
patch:yes
|
@pocka this also needs to be patched back to master, correct? if so, i'll take care of it. |
|
@shilman Yes, please 🙏 |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Mar 3, 2021
IE11: Transpile prettier down to ES5
|
Thank you! I was just discussing a need for this with my teammates and then this PR is merged. |
This was referenced Mar 7, 2021
Closed
This was referenced Mar 14, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13562
What I did
Transpile prettier down to ES5.
All of the remaining 16
=>s are in regexp literals or string literals (checked manually).NOTE: I'm not sure what label is appropriate so just added
bugandie11labelsHow to test
If your answer is yes to any of these, please make sure to include it in your PR.