Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self-closing div tag, which is invalid HTML #148

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

wyattdanger
Copy link
Contributor

Removes a self-closing div tag, because there is no such thing as a self-closing div tag (unless you're serving up XHTML) and older IEs get mad about it

screen shot 2016-04-25 at 1 49 07 pm

@arunoda
Copy link
Member

arunoda commented Apr 25, 2016

Could you merge your branch with the our latest master branch.
Seems like there are some conflicts.

@wyattdanger wyattdanger force-pushed the swb--no-self-close-div branch 5 times, most recently from b30bf89 to 01fa897 Compare April 26, 2016 00:46
@wyattdanger
Copy link
Contributor Author

@arunoda it is now rebased, conflicts are resolved

@arunoda
Copy link
Member

arunoda commented Apr 26, 2016

Awesome.

@arunoda arunoda merged commit 2e9e392 into storybookjs:master Apr 26, 2016
@shilman shilman added the misc label May 27, 2017
Copy link

nx-cloud bot commented Nov 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 658865a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants