Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaking @types/* from package.json dependencies #18169

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/links/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"@storybook/core-events": "6.5.0-rc.1",
"@storybook/csf": "0.0.2--canary.4566f4d.1",
"@storybook/router": "6.5.0-rc.1",
"@types/qs": "^6.9.5",
mrauhu marked this conversation as resolved.
Show resolved Hide resolved
"core-js": "^3.8.2",
"global": "^4.4.0",
"prop-types": "^15.7.2",
Expand All @@ -55,6 +54,7 @@
"ts-dedent": "^2.0.0"
},
"devDependencies": {
"@types/qs": "^6.9.5",
"@types/webpack-env": "^1.16.0"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion addons/storyshots/storyshots-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
"@storybook/core-common": "6.5.0-rc.1",
"@storybook/csf": "0.0.2--canary.4566f4d.1",
"@types/glob": "^7.1.3",
"@types/jest": "^26.0.16",
"@types/jest-specific-snapshot": "^0.5.3",
"core-js": "^3.8.2",
"glob": "^7.1.6",
Expand All @@ -75,6 +74,7 @@
"@storybook/react": "6.5.0-rc.1",
"@storybook/vue": "6.5.0-rc.1",
"@storybook/vue3": "6.5.0-rc.1",
"@types/jest": "^26.0.16",
"babel-loader": "^8.0.0",
"enzyme": "^3.11.0",
"enzyme-to-json": "^3.6.1",
Expand Down
2 changes: 1 addition & 1 deletion lib/builder-webpack4/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
"@storybook/store": "6.5.0-rc.1",
"@storybook/theming": "6.5.0-rc.1",
"@storybook/ui": "6.5.0-rc.1",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/webpack": "^4.41.26",
"autoprefixer": "^9.8.6",
"babel-loader": "^8.0.0",
Expand Down Expand Up @@ -89,6 +88,7 @@
},
"devDependencies": {
"@types/case-sensitive-paths-webpack-plugin": "^2.1.4",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/terser-webpack-plugin": "^4.2.0",
"@types/webpack-dev-middleware": "^3.7.3",
"@types/webpack-hot-middleware": "<=2.25.5",
Expand Down
2 changes: 1 addition & 1 deletion lib/builder-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"@storybook/semver": "^7.3.2",
"@storybook/store": "6.5.0-rc.1",
"@storybook/theming": "6.5.0-rc.1",
"@types/node": "^14.0.10 || ^16.0.0",
"babel-loader": "^8.0.0",
"babel-plugin-named-exports-order": "^0.0.2",
"browser-assert": "^1.2.1",
Expand All @@ -80,6 +79,7 @@
},
"devDependencies": {
"@types/case-sensitive-paths-webpack-plugin": "^2.1.4",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/terser-webpack-plugin": "^5.0.2",
"@types/webpack-dev-middleware": "^4.1.0",
"@types/webpack-hot-middleware": "^2.25.6",
Expand Down
2 changes: 1 addition & 1 deletion lib/core-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"@babel/register": "^7.12.1",
"@storybook/node-logger": "6.5.0-rc.1",
"@storybook/semver": "^7.3.2",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/pretty-hrtime": "^1.0.0",
"babel-loader": "^8.0.0",
"babel-plugin-macros": "^3.0.1",
Expand Down Expand Up @@ -96,6 +95,7 @@
"@types/compression": "^1.7.0",
"@types/interpret": "^1.1.1",
"@types/mock-fs": "^4.13.0",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/picomatch": "^2.3.0",
"mock-fs": "^4.13.0"
},
Expand Down
6 changes: 3 additions & 3 deletions lib/core-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@
"@storybook/semver": "^7.3.2",
"@storybook/store": "6.5.0-rc.1",
"@storybook/telemetry": "6.5.0-rc.1",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/node-fetch": "^2.5.7",
"@types/pretty-hrtime": "^1.0.0",
"@types/webpack": "^4.41.26",
"better-opn": "^2.1.1",
"boxen": "^5.1.2",
Expand Down Expand Up @@ -88,6 +85,9 @@
"@storybook/builder-webpack5": "6.5.0-rc.1",
"@types/compression": "^1.7.0",
"@types/ip": "^1.1.0",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/node-fetch": "^2.5.7",
"@types/pretty-hrtime": "^1.0.0",
"@types/serve-favicon": "^2.5.2",
"@types/ws": "^8",
"jest-specific-snapshot": "^4.0.0"
Expand Down
2 changes: 1 addition & 1 deletion lib/manager-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"@storybook/node-logger": "6.5.0-rc.1",
"@storybook/theming": "6.5.0-rc.1",
"@storybook/ui": "6.5.0-rc.1",
"@types/node": "^14.0.10 || ^16.0.0",
"babel-loader": "^8.0.0",
"case-sensitive-paths-webpack-plugin": "^2.3.0",
"chalk": "^4.1.0",
Expand All @@ -77,6 +76,7 @@
},
"devDependencies": {
"@types/case-sensitive-paths-webpack-plugin": "^2.1.4",
"@types/node": "^14.0.10 || ^16.0.0",
"@types/terser-webpack-plugin": "^5.0.2",
"@types/webpack-dev-middleware": "^4.1.0",
"@types/webpack-virtual-modules": "^0.1.0"
Expand Down