Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "React" references #1834

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Removed "React" references #1834

merged 1 commit into from
Sep 12, 2017

Conversation

nblackburn
Copy link
Contributor

@nblackburn nblackburn commented Sep 12, 2017

Issue:

What I did

Removed React references so it more accurately reflects support for other frameworks.

@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #1834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5739     5739           
  Branches      684      687    +3     
=======================================
  Hits         1224     1224           
- Misses       3995     4009   +14     
+ Partials      520      506   -14
Impacted Files Coverage Δ
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f077e6a...e4e6368. Read the comment docs.

@ndelangen ndelangen merged commit 3bdf6c2 into storybookjs:master Sep 12, 2017
@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog documentation labels Sep 12, 2017
@nblackburn nblackburn deleted the patch-1 branch September 12, 2017 09:46
@ndelangen
Copy link
Member

Thank you @nblackburn!, I'm surprised this has one unnoticed for so long.

I'll redeploy end of the day.

@nblackburn
Copy link
Contributor Author

@ndelangen Haha, i was a surprise to me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants