Feat/addons docs tsup #18788
Feat/addons docs tsup #18788
Conversation
|
Based on this deployment failure: https://app.netlify.com/sites/storybookjs/deploys/62def0a92e5b730008aa0ea6 I am not sure how to export |
# Conflicts: # code/addons/docs/package.json
|
@Saunved Seems this addon is a bit more involved than the others.. Let's revisit this one last. |
|
Yes, it seems a bit complicated. I'll push the remaining ones this week for review! |
| }, | ||
| "dependencies": { | ||
| "@babel/plugin-transform-react-jsx": "^7.12.12", | ||
| "@babel/preset-env": "^7.12.11", | ||
| "@digitak/esrun": "^3.2.2", |
There was a problem hiding this comment.
| "@digitak/esrun": "^3.2.2", |
| @@ -6566,6 +6566,7 @@ __metadata: | |||
| "@babel/core": ^7.12.10 | |||
| "@babel/plugin-transform-react-jsx": ^7.12.12 | |||
| "@babel/preset-env": ^7.12.11 | |||
| "@digitak/esrun": ^3.2.2 | |||
There was a problem hiding this comment.
| "@digitak/esrun": ^3.2.2 |
|
Hello @Saunved sorry this PR was somewhat neglected.. it turned out this package was quite complex, and so I took it over at some point for forgot to inform you. Sorry about that. I hope you don't mind me closing this PR now. Thank you for your time, energy and effort put into this (and the others) PR. It's greatly appreciated! |
Issue: #18732
What I did
Followed the instructions on the issue mentioned above
How to test
If your answer is yes to any of these, please make sure to include it in your PR.