Build: Fix the sb-bench CI step #19029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
Emotion changed to use exports map, and esbuild wasn't pivking the right entry anymore, resulting in react not being detected, and thus not bundled, and thus missing at runtime! I changed the tsup/esbuild config to prefer the ESM version, and this seems to have fixed the issue. Many thanks to @anderist for the assist!
…the suggested fix by @anderist He suggested that 'hiding' the dependency on an export that may or may not exists away from bundlers would solve it. This is what they do in emotion itself, but esbuild optimizes that away again.
Andarist
reviewed
Aug 26, 2022
| @@ -80,6 +80,7 @@ const run = async ({ cwd, flags }: { cwd: string; flags: string[] }) => { | |||
| : false, | |||
| esbuildOptions: (c) => { | |||
| /* eslint-disable no-param-reassign */ | |||
| c.conditions = ['module']; | |||
There was a problem hiding this comment.
I would recheck what kind of an effect does it have on esbuild - is this purely additive to the default conditions? or does it replace them? I think that I was checking this in the past and that this is additive - some default conditions just cant be turned off but I'm not 100% sure.
|
So it seems there's a bunch of these missing / broken: |
# Conflicts: # code/yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The CI task of sb-bench was failing.
related: #18992 I think this replaces it. @Andarist