Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/suppress current eslint warnings #1936

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Conversation

Hypnosphi
Copy link
Member

This also raises import/no-unresolved and import/extensions to error level
everywhere except docs.

I didn't touch the warning about lacking tests for addons/notes so that it keeps reminding that they still have to be written.

It would be nice if we could find a way to know if some new warnings are introduced with a PR (like it's done with code coverage). Does anyone know how to get this metric from CircleCI?

Raise `import/no-unresolved` and `import/extensions` to error level
everywhere except `docs`
@Hypnosphi Hypnosphi added the maintenance User-facing maintenance tasks label Oct 1, 2017
@Hypnosphi Hypnosphi requested a review from a team October 1, 2017 22:53
@Hypnosphi Hypnosphi added the cleanup Minor cleanup style change that won't show up in release changelog label Oct 1, 2017
@codecov
Copy link

codecov bot commented Oct 1, 2017

Codecov Report

Merging #1936 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1936      +/-   ##
==========================================
- Coverage   21.43%   21.38%   -0.06%     
==========================================
  Files         261      262       +1     
  Lines        5743     5757      +14     
  Branches      691      689       -2     
==========================================
  Hits         1231     1231              
- Misses       3987     4010      +23     
+ Partials      525      516       -9
Impacted Files Coverage Δ
addons/graphql/demo/index.js 0% <ø> (ø) ⬆️
lib/ui/example/server.js 0% <ø> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/notes/src/register.js 0% <0%> (ø) ⬆️
addons/graphql/demo/.eslintrc.js 0% <0%> (ø)
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
...ponents/left_panel/stories_tree/tree_decorators.js 33.33% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea0296...2e8240d. Read the comment docs.

Copy link
Member

@usulpro usulpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@igor-dv
Copy link
Member

igor-dv commented Oct 2, 2017

Thinking out loud - can we maybe create a separate CI job for the linting that will be run with the error level for every rule. This job will not prevent anything from merging, but just illustrate the worst picture of the PR.

@Hypnosphi
Copy link
Member Author

a separate CI job for the linting that will be run with the error level for every rule

The problem is it would be red for all subsequent PRs even if they don't introduce new warnings, so it wouldn't really give much value

@Hypnosphi Hypnosphi merged commit 8271ac6 into master Oct 2, 2017
@Hypnosphi Hypnosphi deleted the eliminate-eslint-warnings branch October 2, 2017 09:53
@Hypnosphi Hypnosphi requested a review from a team October 2, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog discussion maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants