Build: Bundle addons/storysource with ts-up #19482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
changed the title
|
Should I include preset.js in the exports field and in the bundle? |
|
I'm not sure, to be honest. Here was a previous attempt at this conversion, FWIW: #19284 I think @ndelangen can provide better guidance here. |
|
It seems javascript files are not allowed by the typescript config of the bundle script. I will convert the preset.js file to ts. |
|
@IanVS Converting preset.js to typescript and including that file in the bundle seems to have worked. CI is green. 🎉 |
ndelangen
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #18732
What I did
Followed the instructions in the above issue
How to test
If your answer is yes to any of these, please make sure to include it in your PR.