Simplify mdxPlugin used in vite builder #19565
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We are currently adding
@vitejs/plugin-react
to every non-react vite storybook project, in order to process the code that is returned from@storybook/mdx2-csf
.What I did
This change pulls in storybookjs/mdx2-csf#20, which swaps out JSX syntax for a call to the
_jsx()
transform instead, which is what the rest of the code returned from@mdxjs/mdx
uses.That allows us to remove the use of the react vite plugin in our custom mdx vite plugin.
How to test
I'm not super-confident in this change, and I'm hoping CI will help give a bit of confidence. But it will need a close look as well. I tested in a react sandbox, but the mdx there is not very complex.