NextJS: Support next/navigation in Next.js v13 #20065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylegach
reviewed
Dec 2, 2022
kylegach
reviewed
Dec 2, 2022
kylegach
reviewed
Dec 2, 2022
kylegach
reviewed
Dec 2, 2022
kylegach
reviewed
Dec 2, 2022
code/frameworks/nextjs/template/stories_default-js/Navigation.stories.jsx
Show resolved
Hide resolved
shilman
reviewed
Dec 3, 2022
code/frameworks/nextjs/template/stories_default-js/Navigation.stories.jsx
Show resolved
Hide resolved
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
valentinpalkovic
force-pushed
the
valentin/support-next-navigation
branch
from
a69be59 to
66f9945
Compare
…pport-next-navigation
valentinpalkovic
force-pushed
the
valentin/document-next-link-component
branch
from
5fa671a to
544d8e5
Compare
valentinpalkovic
changed the base branch from
valentin/document-next-link-component
to
next
yannbf
reviewed
Dec 6, 2022
Co-authored-by: Yann Braga <yannbf@gmail.com>
yannbf
reviewed
Dec 6, 2022
shilman
requested changes
Dec 6, 2022
| }); | ||
|
|
||
| test.describe('next/navigation', () => { | ||
| test.skip( |
There was a problem hiding this comment.
I wonder what this will do to the CI status report? cc @kasperpeulen
There was a problem hiding this comment.
I guess everything will fail. But @kasperpeulen is working on adding metadata to tests, so I hope there's a way to configure this, either by adding the skip descrition or something, which allows us to get the results right
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
kylegach
reviewed
Dec 6, 2022
kylegach
reviewed
Dec 6, 2022
kylegach
reviewed
Dec 6, 2022
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
valentinpalkovic
force-pushed
the
valentin/support-next-navigation
branch
from
33c8925 to
a376841
Compare
kylegach
reviewed
Dec 6, 2022
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
shilman
approved these changes
Dec 7, 2022
shilman
reviewed
Dec 7, 2022
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support next/navigation in Next.js v13.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.