Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Next 12 sandbox #20092

Merged
merged 3 commits into from
Dec 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -611,25 +611,25 @@ workflows:
jobs:
- build
- create-sandboxes:
parallelism: 25
parallelism: 26
requires:
- build
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
parallelism: 25
parallelism: 26
requires:
- create-sandboxes
- test-runner-sandboxes:
parallelism: 25
parallelism: 26
requires:
- build-sandboxes
- chromatic-sandboxes:
parallelism: 25
parallelism: 26
requires:
- build-sandboxes
- e2e-sandboxes:
parallelism: 25
parallelism: 26
requires:
- build-sandboxes
9 changes: 1 addition & 8 deletions code/frameworks/nextjs/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { DefinePlugin } from 'webpack';
import { PHASE_DEVELOPMENT_SERVER } from 'next/constants';
import findUp from 'find-up';
import { pathExists } from 'fs-extra';
import dedent from 'ts-dedent';
import type { Configuration as WebpackConfig } from 'webpack';
import type { NextConfig } from 'next';
import { pathToFileURL } from 'node:url';
Expand Down Expand Up @@ -45,13 +44,7 @@ export const resolveNextConfig = async ({
const nextConfigFile = nextConfigPath || (await findNextConfigFile(configDir));

if (!nextConfigFile || (await pathExists(nextConfigFile)) === false) {
throw new Error(
dedent`
Could not find or resolve your Next config file. Please provide the next config file path as a framework option.

More info: https://github.com/storybookjs/storybook/blob/next/code/frameworks/nextjs/README.md#options
`
);
return {};
}

const nextConfigExport = await import(pathToFileURL(nextConfigFile).href);
Expand Down
1 change: 1 addition & 0 deletions code/lib/cli/src/repro-templates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ export const daily: TemplateKey[] = [
'lit-vite/default-js',
'svelte-kit/skeleton-js',
'svelte-vite/default-js',
'nextjs/12-js',
'nextjs/default-js',
'preact-webpack5/default-js',
];
Expand Down