Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is a PoC on making Vite and the Vite renderer plugins peer dependencies.
It works with Vue and Svelte, but React still breaks with stories in MDX (but plain MDX is fine).
This PR allows both Vite 3 and 4 (except for the SvelteKit framework), we still haven't decided if we want to only support Vite 4 at this point.
I've tested for all three frameworks that it works both when the user supplies Vite 3 and 4 (and matching plugins). Vite 3 + React Plugin 2 makes the stories in MDX work again, as expected.
To do
If we decide this is the path forward
react
andreact-dom
. This is a bit more complex though, as it differs between frameworks@vitejs/plugin-react@^3.0.0
.