-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech: make the version range of vite
also allow for vite
4
#20294
Conversation
vite
also allow for vite
4
It looks like this is an alternate solution to #20281? Is there a reason not to go the route I took there? I'd prefer to keep vite as a peer dependency, as it was in 6.5, and I think we can do it without problem now that we are not injecting the react plugin to handle mdx. |
No there isn't. @JReinhold asked me to look into his svelte PR, and when I did I noticed the yarn failure, so I fixed it, and extracted the fix out into it's own PR here. |
@IanVS I do not know what's going on with that PR, I'm happy to prefer that one over this one, for sure. |
I can't reproduce this unit-test fail locally. Argh I feel like giving up on this. |
I found the issue in the other PR(#20281). |
ok, I'll close it again |
Issue: support vite 4?
What I did
I allowed vite in the version range, this fixes
yarn start
. (in ourcontribution.md
)It might also just be the right thing to do?