Angular: Fix allowed types of webpackStatsJson in angular-builder #20503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore: (Docs) Fix API CLI options documentation
|
🙏 This blocks Chromatic Turbosnap |
3 tasks
valentinpalkovic
previously approved these changes
Jan 12, 2023
|
@shilman any idea why the pipeline is failing? Seems to be unrelated to that change. Can we force merge? |
|
@shilman Can I ignore the failing tests? Can we rely on the pipeline for branches which are based on |
shilman
dismissed
valentinpalkovic’s stale review
The base branch was changed.
shilman
changed the title
|
Closing as duplicate to #20296 which was released in https://github.com/storybookjs/storybook/releases/tag/v6.5.16-alpha.0 and which I'll release today in 6.5.16 proper. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20520
What I did
Backport a fix from
nextbranch tomain.The
--webpack-stats-jsonoption should accept a string (a path) as well.Note that the underlying implementation already accepts a path.
Only the schema was too strict.
Why I did it
Our team is using chromatic.
When using chromatic with turbosnap (
--only-changed), it does expect that the storybook-builder option--webpacks-stats-jsonaccepts a string.