Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: sandbox for pnp #20998

Closed
wants to merge 12 commits into from
Closed

Build: sandbox for pnp #20998

wants to merge 12 commits into from

Conversation

ndelangen
Copy link
Member

extremely experimental

@ndelangen ndelangen self-assigned this Feb 7, 2023
@ndelangen ndelangen added ci: do not merge build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Fails
🚫 PR is marked with "ci: do not merge" label.

Generated by 🚫 dangerJS against bf622c0

@@ -1,17 +1,101 @@
import resolveFrom from 'resolve-from';
import findUp from 'find-up';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brace yourself, this code needs cleanup.. if it works that is..

@storybookjs storybookjs deleted a comment from socket-security bot Feb 10, 2023
@ndelangen
Copy link
Member Author

Ok.. so I think I got this into the shape it can be in and, it doesn't work.

  • I seems my changes trying to fix pnp breaks vite, for some reason.
  • But worse of all, my changes seem to not even fix pnp. Or at the very least I can't get the sandbox to work.

I was able to find where files supposedly are according to pnp by asking the pnp api:
require(pnpFile).resolveRequest('@storybook/addon-docs', './')

This actually yields a place in the fs!
Unfortunately node can't use it, because (I assume) it's in a .zip file.

So I'm afraid this isn't a viable method of suppurting pnp.

@storybookjs storybookjs deleted a comment from socket-security bot Feb 10, 2023
@storybookjs storybookjs deleted a comment from socket-security bot Feb 10, 2023
@ndelangen ndelangen closed this Feb 13, 2023
@stof stof deleted the norbert/investigate-pnp-cli-flag branch August 2, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. ci: do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant