Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Storybook does not respect BROWSER env var #21344

Merged
merged 0 commits into from
Mar 3, 2023
Merged

fix: Storybook does not respect BROWSER env var #21344

merged 0 commits into from
Mar 3, 2023

Conversation

thtliife
Copy link
Contributor

@thtliife thtliife commented Mar 2, 2023

Storybook does not respect BROWSER env var if default browser is not chromium based.

Closes #21343

What I did

This commit adds a check for the environment variable, and passes it to the open package as an argument if the specified browser is not chromium based.

Changes are in code/lib/core-server/src/utils/open-in-browser.ts

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday merged commit 485fd3a into storybookjs:next Mar 3, 2023
@thtliife
Copy link
Contributor Author

thtliife commented Mar 5, 2023

erm, pull bot undid my changes? this no longer fixes anything

@tmeasday
Copy link
Member

tmeasday commented Mar 5, 2023

I've no idea what's going on here. I definitely didn't merge anything. And that commit (485fd3a) points to an apparently unrelated @shilman commit...

@shilman
Copy link
Member

shilman commented Mar 13, 2023

What is the "pull" bot? Seems buggy to me

@thtliife
Copy link
Contributor Author

thtliife commented Mar 13, 2023

@shilman Haha. It’s a bot that I had forgotten I had installed in my sccount.
it’s supposed to keep forks up to date with their parent repos…
But it seemed to have been doing a git fetch —hard
Needless to say it’s no longer installed in my account 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook does not respect BROWSER env var if default browser is not chromium based.
3 participants